Skip to content

fix: do not trim stdout of clang-format process #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix: do not trim stdout of clang-format process #1623

merged 1 commit into from
Nov 8, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

To avoid hitting a no newline at the end of file problem with the formatted.

Change description

Do not trim the stdout of clang-format process.

Other information

Closes #1487

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: do not trim stdout of clang-format process
ed2b302 
Otherwise, it always causes a _no newline at the end of file_ problem.

Closes #1487

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 3, 2022
@kittaakos kittaakos marked this pull request as ready for review November 7, 2022 13:06
per1234
per1234 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1487

Thanks Akos!

francescospissu
francescospissu approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the code looks fine 👍

@kittaakos kittaakos merged commit 3a70547 into main Nov 8, 2022
@kittaakos kittaakos deleted the #1487 branch November 8, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@francescospissu francescospissu francescospissu approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoformat removes new-line before EOF
3 participants
@kittaakos @per1234 @francescospissu